]> git.karo-electronics.de Git - linux-beck.git/commit
drbd: fix "endless" transfer log walk in protocol A
authorLars Ellenberg <lars.ellenberg@linbit.com>
Mon, 18 May 2015 12:08:46 +0000 (14:08 +0200)
committerJens Axboe <axboe@fb.com>
Wed, 25 Nov 2015 16:22:03 +0000 (09:22 -0700)
commitf85d9f2d02cdcd1b79e00fccd667b37b251ba3ac
tree44a62bbab00dc8eecfbdd9ab312eb4686994704c
parent706447861bb210cf2fb6a58bc1d29a6636175987
drbd: fix "endless" transfer log walk in protocol A

Don't remember a DRBD request as ack_pending, if it is not.

In protocol A, we usually clear RQ_NET_PENDING at the same time we set
RQ_NET_SENT, so when deciding to remember it as ack_pending,
mod_rq_state needs to look at the current request state,
not at the previous state before the current modification was applied.

This should prevent advance_conn_req_ack_pending() from walking the full
transfer log just to find NULL in protocol A, which would cause serious
performance degradation with many "in-flight" requests, e.g. when
working via DRBD-proxy, or with a huge bandwidth-delay product.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/drbd/drbd_req.c