]> git.karo-electronics.de Git - karo-tx-linux.git/commit
usb: core: use kbasename() instead of open-coded variant
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 10 Dec 2015 14:49:14 +0000 (16:49 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Jan 2016 04:37:47 +0000 (20:37 -0800)
commitf8868ed0078a8456ac725103a97cbe6d833e13f3
treee4965335c3a8faf015011ad3d078280505892695
parent6f5429d986f81a5c16d451c5d63d829a785f470a
usb: core: use kbasename() instead of open-coded variant

kbasename() helper is dedicated to find a last part of the filename or
pathname. USB core uses open-coded variant of that helper.

Replace some lines of code by kbasename() call.

The current users do not have trailing slash and we are on the safe side to
make such change. I dig a history of the code under question up and found the
patch [1] that brought it along with the same to tty layer. The check for
trailing slash looks like copy'n'paste thing and I consider it as redundant.

[1] http://www.kernel.org/pub/linux/kernel//people/akpm/patches/2.5/2.5.69/2.5.69-mm3/broken-out/linus.patch

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/file.c