]> git.karo-electronics.de Git - linux-beck.git/commit
USB: serial: remove zte_ev driver
authorJohan Hovold <johan@kernel.org>
Mon, 15 Sep 2014 16:40:45 +0000 (18:40 +0200)
committerJohan Hovold <johan@kernel.org>
Mon, 15 Sep 2014 16:43:08 +0000 (18:43 +0200)
commitf8c0e057b4898055b24b44d03b837a15d8b93b37
treed3998d35f8917010562abbee6e7d8ede4b73c232
parent4b7154ba70bb20a3c024faabdd2bc207b550a813
USB: serial: remove zte_ev driver

The zte_ev driver is based on code (once) distributed by ZTE that still
appears to originally have been reverse-engineered and bolted onto the
generic driver.

A closer analysis of the zte_ev setup code reveals that it consists of
standard CDC requests (SET/GET_LINE_CODING and SET_CONTROL_LINE_STATE)
but unfortunately fails to get some of those right. In particular, as
reported by Lei Liu, it fails to lower DTR/RTS on close. It also appears
that the control requests lack the interface argument.

Since line control is already handled properly by the option driver, and
the SET/GET_LINE_CODING requests appears to be redundant (amounts to a
SET 9600 8N1) let's remove the redundant zte_ev driver.

Also move the remaining ZTE PIDs to the generic option modem driver.

Reported-by: Lei Liu <liu.lei78@zte.com.cn>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/Kconfig
drivers/usb/serial/Makefile
drivers/usb/serial/option.c
drivers/usb/serial/zte_ev.c [deleted file]