]> git.karo-electronics.de Git - linux-beck.git/commit
mtd: nuc900_nand: read correct SMISR register
authorArnd Bergmann <arnd@arndb.de>
Wed, 13 Jan 2016 21:38:08 +0000 (22:38 +0100)
committerBrian Norris <computersforpeace@gmail.com>
Fri, 15 Jan 2016 18:02:09 +0000 (10:02 -0800)
commitf9bdbd6c46c8ce0bb95f5b708a4a4a4b6b9a5917
treed8a2468922595fc3437cad0aa41dc33f84170834
parent92752d9974882e2e5384e92668f02a134f9c7463
mtd: nuc900_nand: read correct SMISR register

The nuc900_nand driver has always passed an incorrect register
address in its nuc900_check_rb() function, which cannot possibly
work, and in some configurations gives us a build warning:

drivers/mtd/nand/nuc900_nand.c: In function 'nuc900_check_rb':
drivers/mtd/nand/nuc900_nand.c:27:23: warning: passing argument 1 of '__raw_readl' makes pointer from integer without a cast [-Wint-conversion]
 #define REG_SMISR     0xac
drivers/mtd/nand/nuc900_nand.c:118:20: note: in expansion of macro 'REG_SMISR'
  val = __raw_readl(REG_SMISR);

This makes sure we actually read from the register rather than
from (void *)0x000000ac in user space.

I suspect nobody noticed this before because the nuc900_nand_devready()
function never gets called, or nobody uses this driver on an upstream
kernel. Possibly even both.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
drivers/mtd/nand/nuc900_nand.c