]> git.karo-electronics.de Git - linux-beck.git/commit
gpio: mpc8xxx: Fixup setting gpio direction output
authorAxel Lin <axel.lin@ingics.com>
Mon, 22 Feb 2016 07:22:52 +0000 (15:22 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 9 Mar 2016 03:41:23 +0000 (10:41 +0700)
commitfa4007ca06e4c808b002067c2ea02a9bebdc044b
tree3423b11e0375a5a398890031ecb048737a536eb8
parent28c5a41e4aa44f162297d596030900b90aa1cf08
gpio: mpc8xxx: Fixup setting gpio direction output

For devtype with specific gpio_dir_out implementation, current code is
wrong because below code sets both gc->direction_output and
mpc8xxx_gc->direction_output to the same function.

gc->direction_output = devtype->gpio_dir_out ?: gc->direction_output;
mpc8xxx_gc->direction_output = gc->direction_output;

Set mpc8xxx_gc->direction_output = gc->direction_output first to fix it.
This way mpc8xxx_gc->direction_output actually calls the standard
bgpio_dir_out() to update register.

Fixes: commit 42178e2a1e42 ("drivers/gpio: Switch gpio-mpc8xxx to use gpio-generic")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-mpc8xxx.c