]> git.karo-electronics.de Git - karo-tx-linux.git/commit
staging: comedi: usbduxfast: consolidate the firmware upload
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Tue, 14 May 2013 20:40:24 +0000 (13:40 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 May 2013 23:24:29 +0000 (16:24 -0700)
commitfbe38a8b3580aa0b9a842072de8ddd6510b1e522
tree15a51b60213fe7d9f404cdc30195d94105303d33
parentdcd29f56e58ecffe68f381910a4cecbeba37594c
staging: comedi: usbduxfast: consolidate the firmware upload

Absorb the usbduxfastsub_stop(), usbduxfastsub_upload(), and
usbduxfastsub_start() functions into usbduxfast_upload_firmware().

Each of them just do a usb_control_msg() to the device and output
an error message if it fails. A similar message is also output by
usbduxfast_upload_firmware() so the extra messages are redundant.

We can also share the malloc'ed local buffer needed for the
usb_control_msg().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/usbduxfast.c