]> git.karo-electronics.de Git - karo-tx-linux.git/commit
xfs: log recovery needs to validate against sb_meta_uuid
authorDave Chinner <dchinner@redhat.com>
Wed, 19 Aug 2015 00:31:54 +0000 (10:31 +1000)
committerDave Chinner <david@fromorbit.com>
Wed, 19 Aug 2015 00:31:54 +0000 (10:31 +1000)
commitfcfbe2c4ef4243cc11a1cd64ee1b4907b6afea06
tree8f96db333c8177d7c933725e83dcd71f9e7f3012
parentac383de20d468a75e7023caf06dcf6606cd85220
xfs: log recovery needs to validate against sb_meta_uuid

Now that sb_uuid can be changed by the user, we cannot use this to
validate the metadata blocks being recovered belong to this
filesystem. We must check against the sb_meta_uuid as that will
remain unchanged.

There is a complication in this code - the superblock itself. We can
not check the sb_meta_uuid unconditionally, as that may not be set
on disk. Hence we must verify the superblock sb_uuid matches between
the log record and the in-core superblock.

Found by inspection after the previous two problems were found.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_log_recover.c