]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ARM: 7403/1: tls: remove covert channel via TPIDRURW
authorWill Deacon <will.deacon@arm.com>
Fri, 27 Apr 2012 11:45:07 +0000 (12:45 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 11 May 2012 12:14:46 +0000 (13:14 +0100)
commitfdd90d60811d751c71e8fd19235fabc9cd7d4307
treefced76362226507f0a2f7b5c4a318ec943802a81
parent989046b49627c1beacad7517d044401f14bbd53c
ARM: 7403/1: tls: remove covert channel via TPIDRURW

commit 6a1c53124aa161eb624ce7b1e40ade728186d34c upstream.

TPIDRURW is a user read/write register forming part of the group of
thread registers in more recent versions of the ARM architecture (~v6+).

Currently, the kernel does not touch this register, which allows tasks
to communicate covertly by reading and writing to the register without
context-switching affecting its contents.

This patch clears TPIDRURW when TPIDRURO is updated via the set_tls
macro, which is called directly from __switch_to. Since the current
behaviour makes the register useless to userspace as far as thread
pointers are concerned, simply clearing the register (rather than saving
and restoring it) will not cause any problems to userspace.

Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/arm/include/asm/tls.h