]> git.karo-electronics.de Git - karo-tx-linux.git/commit
setup_arg_pages: diagnose excessive argument size
authorRoland McGrath <roland@redhat.com>
Wed, 8 Sep 2010 02:35:49 +0000 (19:35 -0700)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Thu, 6 Jan 2011 23:08:17 +0000 (18:08 -0500)
commitfe3a036d4230f0268aec6409ec396b323c0b1f0e
treec5d3b5d9cd32f2f82e0d6d32d1f4f7caef9b43ea
parentd21e190e40650c71daa45d953c1ea05771234424
setup_arg_pages: diagnose excessive argument size

commit 1b528181b2ffa14721fb28ad1bd539fe1732c583 upstream.

The CONFIG_STACK_GROWSDOWN variant of setup_arg_pages() does not
check the size of the argument/environment area on the stack.
When it is unworkably large, shift_arg_pages() hits its BUG_ON.
This is exploitable with a very large RLIMIT_STACK limit, to
create a crash pretty easily.

Check that the initial stack is not too large to make it possible
to map in any executable.  We're not checking that the actual
executable (or intepreter, for binfmt_elf) will fit.  So those
mappings might clobber part of the initial stack mapping.  But
that is just userland lossage that userland made happen, not a
kernel problem.

Signed-off-by: Roland McGrath <roland@redhat.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
fs/exec.c