The mm::start_code, end_code, start_data, end_data members are set during
startup of executable file and are not changed after.
But the program itself might map new executable or/and data areas in time
so the original values written into mm fields mentioned above might not
have correspond VMA area at all, thus if one try to use this prctl codes
without underlied VMA, the error will be returned.
Drop this requirement. This shrinks the code and eliminates redundant
calls to vma_flags_mismatch. The worst thing one can do (if say to write
some bad values here) -- the weird results will be shown in
/proc/$pid/statm or in /proc/pid/stat.
Still, assignement of data on stack (such as command line and environment
variables) requires the underlied VMA to exist.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Kees Cook <keescook@chromium.org>
Cc: Tejun Heo <tj@kernel.org>
Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
Cc: Pavel Emelyanov <xemul@parallels.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
if (addr >= TASK_SIZE)
return -EINVAL;
if (addr >= TASK_SIZE)
return -EINVAL;
down_read(&mm->mmap_sem);
vma = find_vma(mm, addr);
down_read(&mm->mmap_sem);
vma = find_vma(mm, addr);
- if (opt != PR_SET_MM_START_BRK &&
- opt != PR_SET_MM_BRK &&
- opt != PR_SET_MM_AUXV) {
- /* It must be existing VMA */
- if (!vma || vma->vm_start > addr)
- goto out;
- }
-
switch (opt) {
case PR_SET_MM_START_CODE:
switch (opt) {
case PR_SET_MM_START_CODE:
+ mm->start_code = addr;
+ break;
- if (vma_flags_mismatch(vma, VM_READ | VM_EXEC,
- VM_WRITE | VM_MAYSHARE))
- goto out;
-
- if (opt == PR_SET_MM_START_CODE)
- mm->start_code = addr;
- else
- mm->end_code = addr;
case PR_SET_MM_START_DATA:
case PR_SET_MM_START_DATA:
+ mm->start_data = addr;
+ break;
- if (vma_flags_mismatch(vma, VM_READ | VM_WRITE,
- VM_EXEC | VM_MAYSHARE))
- goto out;
-
- if (opt == PR_SET_MM_START_DATA)
- mm->start_data = addr;
- else
- mm->end_data = addr;
break;
case PR_SET_MM_START_BRK:
break;
case PR_SET_MM_START_BRK:
case PR_SET_MM_ARG_END:
case PR_SET_MM_ENV_START:
case PR_SET_MM_ENV_END:
case PR_SET_MM_ARG_END:
case PR_SET_MM_ENV_START:
case PR_SET_MM_ENV_END:
#ifdef CONFIG_STACK_GROWSUP
if (vma_flags_mismatch(vma, VM_READ | VM_WRITE | VM_GROWSUP, 0))
#else
#ifdef CONFIG_STACK_GROWSUP
if (vma_flags_mismatch(vma, VM_READ | VM_WRITE | VM_GROWSUP, 0))
#else