No need for all tools to register it and then immediately call
perf_session__process_events.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <
1260741029-4430-3-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
{
struct perf_session *session = perf_session__new(input_name, O_RDONLY,
force);
{
struct perf_session *session = perf_session__new(input_name, O_RDONLY,
force);
int ret;
if (session == NULL)
return -ENOMEM;
int ret;
if (session == NULL)
return -ENOMEM;
- idle = register_idle_thread();
-
ret = perf_session__process_events(session, &event_ops, 0,
&event__cwdlen, &event__cwd);
if (ret)
ret = perf_session__process_events(session, &event_ops, 0,
&event__cwdlen, &event__cwd);
if (ret)
if (session == NULL)
return -ENOMEM;
if (session == NULL)
return -ENOMEM;
- register_idle_thread();
err = perf_session__process_events(session, &event_ops, 0,
&event__cwdlen, &event__cwd);
perf_session__delete(session);
err = perf_session__process_events(session, &event_ops, 0,
&event__cwdlen, &event__cwd);
perf_session__delete(session);
static int __cmd_report(void)
{
static int __cmd_report(void)
{
int ret;
struct perf_session *session;
int ret;
struct perf_session *session;
if (session == NULL)
return -ENOMEM;
if (session == NULL)
return -ENOMEM;
- idle = register_idle_thread();
- thread__comm_adjust(idle);
-
if (show_threads)
perf_read_values_init(&show_threads_values);
if (show_threads)
perf_read_values_init(&show_threads_values);
if (session == NULL)
return -ENOMEM;
if (session == NULL)
return -ENOMEM;
- register_idle_thread();
-
err = perf_session__process_events(session, &event_ops, 0,
&event__cwdlen, &event__cwd);
perf_session__delete(session);
err = perf_session__process_events(session, &event_ops, 0,
&event__cwdlen, &event__cwd);
perf_session__delete(session);
static int __cmd_trace(struct perf_session *session)
{
static int __cmd_trace(struct perf_session *session)
{
- register_idle_thread();
return perf_session__process_events(session, &event_ops, 0,
&event__cwdlen, &event__cwd);
}
return perf_session__process_events(session, &event_ops, 0,
&event__cwdlen, &event__cwd);
}
#include "symbol.h"
#include "util.h"
#include "debug.h"
#include "symbol.h"
#include "util.h"
#include "debug.h"
#include "session.h"
static unsigned long mmap_window = 32;
#include "session.h"
static unsigned long mmap_window = 32;
+static struct thread *perf_session__register_idle_thread(struct perf_session *self __used)
+{
+ struct thread *thread = threads__findnew(0);
+
+ if (!thread || thread__set_comm(thread, "swapper")) {
+ pr_err("problem inserting idle task.\n");
+ thread = NULL;
+ }
+
+ return thread;
+}
+
int perf_session__process_events(struct perf_session *self,
struct perf_event_ops *ops,
int full_paths, int *cwdlen, char **cwd)
int perf_session__process_events(struct perf_session *self,
struct perf_event_ops *ops,
int full_paths, int *cwdlen, char **cwd)
uint32_t size;
char *buf;
uint32_t size;
char *buf;
+ if (perf_session__register_idle_thread(self) == NULL)
+ return -ENOMEM;
+
perf_event_ops__fill_defaults(ops);
page_size = getpagesize();
perf_event_ops__fill_defaults(ops);
page_size = getpagesize();
-struct thread *register_idle_thread(void)
-{
- struct thread *thread = threads__findnew(0);
-
- if (!thread || thread__set_comm(thread, "swapper")) {
- fprintf(stderr, "problem inserting idle task.\n");
- exit(-1);
- }
-
- return thread;
-}
-
static void map_groups__remove_overlappings(struct map_groups *self,
struct map *map)
{
static void map_groups__remove_overlappings(struct map_groups *self,
struct map *map)
{
int thread__set_comm(struct thread *self, const char *comm);
int thread__comm_len(struct thread *self);
struct thread *threads__findnew(pid_t pid);
int thread__set_comm(struct thread *self, const char *comm);
int thread__comm_len(struct thread *self);
struct thread *threads__findnew(pid_t pid);
-struct thread *register_idle_thread(void);
void thread__insert_map(struct thread *self, struct map *map);
int thread__fork(struct thread *self, struct thread *parent);
size_t map_groups__fprintf_maps(struct map_groups *self, FILE *fp);
void thread__insert_map(struct thread *self, struct map *map);
int thread__fork(struct thread *self, struct thread *parent);
size_t map_groups__fprintf_maps(struct map_groups *self, FILE *fp);