The names of the functions used for blocking/unblocking EC
transactions during suspend/hibernation suggest that the transactions
are suspended and resumed by them, while in fact they are disabled
and enabled. Rename the functions (and the flag used by them) to
better reflect what they really do.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Len Brown <len.brown@intel.com>
EC_FLAGS_GPE_STORM, /* GPE storm detected */
EC_FLAGS_HANDLERS_INSTALLED, /* Handlers for GPE and
* OpReg are installed */
EC_FLAGS_GPE_STORM, /* GPE storm detected */
EC_FLAGS_HANDLERS_INSTALLED, /* Handlers for GPE and
* OpReg are installed */
- EC_FLAGS_FROZEN, /* Transactions are suspended */
+ EC_FLAGS_BLOCKED, /* Transactions are blocked */
};
/* If we find an EC via the ECDT, we need to keep a ptr to its context */
};
/* If we find an EC via the ECDT, we need to keep a ptr to its context */
if (t->rdata)
memset(t->rdata, 0, t->rlen);
mutex_lock(&ec->lock);
if (t->rdata)
memset(t->rdata, 0, t->rlen);
mutex_lock(&ec->lock);
- if (test_bit(EC_FLAGS_FROZEN, &ec->flags)) {
+ if (test_bit(EC_FLAGS_BLOCKED, &ec->flags)) {
status = -EINVAL;
goto unlock;
}
status = -EINVAL;
goto unlock;
}
EXPORT_SYMBOL(ec_transaction);
EXPORT_SYMBOL(ec_transaction);
-void acpi_ec_suspend_transactions(void)
+void acpi_ec_block_transactions(void)
{
struct acpi_ec *ec = first_ec;
{
struct acpi_ec *ec = first_ec;
mutex_lock(&ec->lock);
/* Prevent transactions from being carried out */
mutex_lock(&ec->lock);
/* Prevent transactions from being carried out */
- set_bit(EC_FLAGS_FROZEN, &ec->flags);
+ set_bit(EC_FLAGS_BLOCKED, &ec->flags);
mutex_unlock(&ec->lock);
}
mutex_unlock(&ec->lock);
}
-void acpi_ec_resume_transactions(void)
+void acpi_ec_unblock_transactions(void)
{
struct acpi_ec *ec = first_ec;
{
struct acpi_ec *ec = first_ec;
mutex_lock(&ec->lock);
/* Allow transactions to be carried out again */
mutex_lock(&ec->lock);
/* Allow transactions to be carried out again */
- clear_bit(EC_FLAGS_FROZEN, &ec->flags);
+ clear_bit(EC_FLAGS_BLOCKED, &ec->flags);
mutex_unlock(&ec->lock);
}
mutex_unlock(&ec->lock);
}
-void acpi_ec_resume_transactions_early(void)
+void acpi_ec_unblock_transactions_early(void)
{
/*
* Allow transactions to happen again (this function is called from
* atomic context during wakeup, so we don't need to acquire the mutex).
*/
if (first_ec)
{
/*
* Allow transactions to happen again (this function is called from
* atomic context during wakeup, so we don't need to acquire the mutex).
*/
if (first_ec)
- clear_bit(EC_FLAGS_FROZEN, &first_ec->flags);
+ clear_bit(EC_FLAGS_BLOCKED, &first_ec->flags);
}
static int acpi_ec_query_unlocked(struct acpi_ec *ec, u8 * data)
}
static int acpi_ec_query_unlocked(struct acpi_ec *ec, u8 * data)
int acpi_ec_init(void);
int acpi_ec_ecdt_probe(void);
int acpi_boot_ec_enable(void);
int acpi_ec_init(void);
int acpi_ec_ecdt_probe(void);
int acpi_boot_ec_enable(void);
-void acpi_ec_suspend_transactions(void);
-void acpi_ec_resume_transactions(void);
-void acpi_ec_resume_transactions_early(void);
+void acpi_ec_block_transactions(void);
+void acpi_ec_unblock_transactions(void);
+void acpi_ec_unblock_transactions_early(void);
/*--------------------------------------------------------------------------
Suspend/Resume
/*--------------------------------------------------------------------------
Suspend/Resume
{
acpi_disable_all_gpes();
acpi_os_wait_events_complete(NULL);
{
acpi_disable_all_gpes();
acpi_os_wait_events_complete(NULL);
- acpi_ec_suspend_transactions();
+ acpi_ec_block_transactions();
*/
acpi_disable_all_gpes();
/* Allow EC transactions to happen. */
*/
acpi_disable_all_gpes();
/* Allow EC transactions to happen. */
- acpi_ec_resume_transactions_early();
+ acpi_ec_unblock_transactions_early();
local_irq_restore(flags);
printk(KERN_DEBUG "Back to C!\n");
local_irq_restore(flags);
printk(KERN_DEBUG "Back to C!\n");
static void acpi_suspend_finish(void)
{
static void acpi_suspend_finish(void)
{
- acpi_ec_resume_transactions();
+ acpi_ec_unblock_transactions();
static void acpi_hibernation_finish(void)
{
hibernate_nvs_free();
static void acpi_hibernation_finish(void)
{
hibernate_nvs_free();
- acpi_ec_resume_transactions();
+ acpi_ec_unblock_transactions();
/* Restore the NVS memory area */
hibernate_nvs_restore();
/* Allow EC transactions to happen. */
/* Restore the NVS memory area */
hibernate_nvs_restore();
/* Allow EC transactions to happen. */
- acpi_ec_resume_transactions_early();
+ acpi_ec_unblock_transactions_early();
}
static void acpi_pm_thaw(void)
{
}
static void acpi_pm_thaw(void)
{
- acpi_ec_resume_transactions();
+ acpi_ec_unblock_transactions();
acpi_enable_all_runtime_gpes();
}
acpi_enable_all_runtime_gpes();
}