]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: android: Use devm_kcalloc instead of devm_kzalloc
authorAmitoj Kaur Chawla <amitoj1606@gmail.com>
Thu, 25 Feb 2016 14:51:20 +0000 (20:21 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 Mar 2016 06:09:09 +0000 (22:09 -0800)
Replace devm_kzalloc with devm_kcalloc to ensure there are no integer
overflows from the multiplication of a number * sizeof.

The following Coccinelle semantic patch was used to make this change:
//<smpl>
@@
expression dev,E1,E2,E3;
@@
- devm_kzalloc(dev,E1*sizeof(E2),E3)
+ devm_kcalloc(dev,E1,sizeof(E2),E3)
//</smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/android/timed_gpio.c

index bcd9924d4631234fd1ed016deb519ee36de1b36c..914fd1005467e3f90fdab2a4bce0e586294e9752 100644 (file)
@@ -92,9 +92,8 @@ static int timed_gpio_probe(struct platform_device *pdev)
        if (!pdata)
                return -EBUSY;
 
-       gpio_data = devm_kzalloc(&pdev->dev,
-                                sizeof(*gpio_data) * pdata->num_gpios,
-                                GFP_KERNEL);
+       gpio_data = devm_kcalloc(&pdev->dev, pdata->num_gpios,
+                                sizeof(*gpio_data), GFP_KERNEL);
        if (!gpio_data)
                return -ENOMEM;