]> git.karo-electronics.de Git - linux-beck.git/commitdiff
usb: dwc2: Remove unnecessary request length checking
authorRazmik Karapetyan <razmik@synopsys.com>
Wed, 16 Nov 2016 23:33:59 +0000 (15:33 -0800)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Fri, 18 Nov 2016 11:54:53 +0000 (13:54 +0200)
Remove request length checking from dwc2_hsotg_unmap_dma() and
dwc2_hsotg_map_dma(). That checking is done in functions called from
those functions, usb_gadget_unmap_request_by_dev() and
usb_gadget_map_request_by_dev() respectively, so it's unnecessary.

Signed-off-by: Razmik Karapetyan <razmik@synopsys.com>
Signed-off-by: John Youn <johnyoun@synopsys.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc2/gadget.c

index 39eccbb008b74ce6075ffbf8be2b495e1c790dca..b95930f20d906dfc02d4d6db7dbe954e475d11cc 100644 (file)
@@ -316,11 +316,6 @@ static void dwc2_hsotg_unmap_dma(struct dwc2_hsotg *hsotg,
                                struct dwc2_hsotg_req *hs_req)
 {
        struct usb_request *req = &hs_req->req;
-
-       /* ignore this if we're not moving any data */
-       if (hs_req->req.length == 0)
-               return;
-
        usb_gadget_unmap_request(&hsotg->gadget, req, hs_ep->dir_in);
 }
 
@@ -1101,13 +1096,8 @@ static int dwc2_hsotg_map_dma(struct dwc2_hsotg *hsotg,
                             struct dwc2_hsotg_ep *hs_ep,
                             struct usb_request *req)
 {
-       struct dwc2_hsotg_req *hs_req = our_req(req);
        int ret;
 
-       /* if the length is zero, ignore the DMA data */
-       if (hs_req->req.length == 0)
-               return 0;
-
        ret = usb_gadget_map_request(&hsotg->gadget, req, hs_ep->dir_in);
        if (ret)
                goto dma_error;