rtc: ds1374: Merge conditional + WARN_ON()

WARN_ON does both these things in one statement.
Using a better pattern with WARN_ON().

Signed-off-by: Srikant Ritolia <s.ritolia@samsung.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c
index 3b3049c8c9e04ddb8ebfb3c391eba41b320286f3..52429f0a57cc2125e428aa88be917a4268f44b35 100644 (file)
--- a/drivers/rtc/rtc-ds1374.c
+++ b/drivers/rtc/rtc-ds1374.c
@@ -89,10 +89,8 @@ static int ds1374_read_rtc(struct i2c_client *client, u32 *time,
        int ret;
        int i;
 
-       if (nbytes > 4) {
-               WARN_ON(1);
+       if (WARN_ON(nbytes > 4))
                return -EINVAL;
-       }
 
        ret = i2c_smbus_read_i2c_block_data(client, reg, nbytes, buf);