]> git.karo-electronics.de Git - linux-beck.git/commitdiff
cgroup: Use RCU_INIT_POINTER(x, NULL) in cgroup.c
authorMonam Agarwal <monamagarwal123@gmail.com>
Sun, 23 Mar 2014 18:47:18 +0000 (00:17 +0530)
committerTejun Heo <tj@kernel.org>
Mon, 24 Mar 2014 12:48:02 +0000 (08:48 -0400)
This patch replaces rcu_assign_pointer(x, NULL) with
RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a
structure is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to
initialize.  So, rcu_assign_pointer(p, NULL) can be safely converted
to RCU_INIT_POINTER(p, NULL)

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/cgroup.c

index 58c67b3060b5038a9b0fb69c09611d6708f4e6de..e378cb2fac5e446d2a1d8eddeb9c022c1d6260b0 100644 (file)
@@ -3545,7 +3545,7 @@ static void css_release(struct percpu_ref *ref)
        struct cgroup_subsys_state *css =
                container_of(ref, struct cgroup_subsys_state, refcnt);
 
-       rcu_assign_pointer(css->cgroup->subsys[css->ss->id], NULL);
+       RCU_INIT_POINTER(css->cgroup->subsys[css->ss->id], NULL);
        call_rcu(&css->rcu_head, css_free_rcu_fn);
 }