iio: ltr501: Fix proximity threshold boundary check

Currently, proximity sensor boundary check is done
inside the switch block but outside the case
statement.Since this code will never get executed,
moved the check outside the switch case statement.

   867          case IIO_PROXIMITY:
   868                  switch (dir) {
   // Following line has been moved outside the switch block.
   869                  if (val > LTR501_PS_THRESH_MASK)
   870                          return -EINVAL;
   871                  case IIO_EV_DIR_RISING:

Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c
index 280eff19b87243797ba1181a705a116a589f8b0d..64e235281cef7f6703b3b1928953f1eb9b413fb7 100644 (file)
--- a/drivers/iio/light/ltr501.c
+++ b/drivers/iio/light/ltr501.c
@@ -865,9 +865,9 @@ static int ltr501_write_thresh(struct iio_dev *indio_dev,
                        return -EINVAL;
                }
        case IIO_PROXIMITY:
-               switch (dir) {
                if (val > LTR501_PS_THRESH_MASK)
                        return -EINVAL;
+               switch (dir) {
                case IIO_EV_DIR_RISING:
                        mutex_lock(&data->lock_ps);
                        ret = regmap_bulk_write(data->regmap,