[media] v4l2-dv-timings: add v4l2_print_dv_timings helper

Drivers often have to log the contents of a dv_timings struct. Adding
this helper will make it easier for drivers to do so.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c b/drivers/media/v4l2-core/v4l2-dv-timings.c
index 72cf2240bac4a3426f7653feab74c2f51e50feab..917e58ce1f18059e0bbb6f590e6525f998bf9412 100644 (file)
--- a/drivers/media/v4l2-core/v4l2-dv-timings.c
+++ b/drivers/media/v4l2-core/v4l2-dv-timings.c
@@ -223,6 +223,55 @@ bool v4l_match_dv_timings(const struct v4l2_dv_timings *t1,
 }
 EXPORT_SYMBOL_GPL(v4l_match_dv_timings);
 
+void v4l2_print_dv_timings(const char *dev_prefix, const char *prefix,
+                          const struct v4l2_dv_timings *t, bool detailed)
+{
+       const struct v4l2_bt_timings *bt = &t->bt;
+       u32 htot, vtot;
+
+       if (t->type != V4L2_DV_BT_656_1120)
+               return;
+
+       htot = V4L2_DV_BT_FRAME_WIDTH(bt);
+       vtot = V4L2_DV_BT_FRAME_HEIGHT(bt);
+
+       if (prefix == NULL)
+               prefix = "";
+
+       pr_info("%s: %s%ux%u%s%u (%ux%u)\n", dev_prefix, prefix,
+               bt->width, bt->height, bt->interlaced ? "i" : "p",
+               (htot * vtot) > 0 ? ((u32)bt->pixelclock / (htot * vtot)) : 0,
+               htot, vtot);
+
+       if (!detailed)
+               return;
+
+       pr_info("%s: horizontal: fp = %u, %ssync = %u, bp = %u\n",
+                       dev_prefix, bt->hfrontporch,
+                       (bt->polarities & V4L2_DV_HSYNC_POS_POL) ? "+" : "-",
+                       bt->hsync, bt->hbackporch);
+       pr_info("%s: vertical: fp = %u, %ssync = %u, bp = %u\n",
+                       dev_prefix, bt->vfrontporch,
+                       (bt->polarities & V4L2_DV_VSYNC_POS_POL) ? "+" : "-",
+                       bt->vsync, bt->vbackporch);
+       pr_info("%s: pixelclock: %llu\n", dev_prefix, bt->pixelclock);
+       pr_info("%s: flags (0x%x):%s%s%s%s\n", dev_prefix, bt->flags,
+                       (bt->flags & V4L2_DV_FL_REDUCED_BLANKING) ?
+                       " REDUCED_BLANKING" : "",
+                       (bt->flags & V4L2_DV_FL_CAN_REDUCE_FPS) ?
+                       " CAN_REDUCE_FPS" : "",
+                       (bt->flags & V4L2_DV_FL_REDUCED_FPS) ?
+                       " REDUCED_FPS" : "",
+                       (bt->flags & V4L2_DV_FL_HALF_LINE) ?
+                       " HALF_LINE" : "");
+       pr_info("%s: standards (0x%x):%s%s%s%s\n", dev_prefix, bt->standards,
+                       (bt->standards & V4L2_DV_BT_STD_CEA861) ?  " CEA" : "",
+                       (bt->standards & V4L2_DV_BT_STD_DMT) ?  " DMT" : "",
+                       (bt->standards & V4L2_DV_BT_STD_CVT) ?  " CVT" : "",
+                       (bt->standards & V4L2_DV_BT_STD_GTF) ?  " GTF" : "");
+}
+EXPORT_SYMBOL_GPL(v4l2_print_dv_timings);
+
 /*
  * CVT defines
  * Based on Coordinated Video Timings Standard

diff --git a/include/media/v4l2-dv-timings.h b/include/media/v4l2-dv-timings.h
index 4c7bb5491658ce3631ccbf2f0904df4b997549d9..696e5c2fd176a3713c1e0bbeb131d9b3b16e8631 100644 (file)
--- a/include/media/v4l2-dv-timings.h
+++ b/include/media/v4l2-dv-timings.h
@@ -76,6 +76,15 @@ bool v4l_match_dv_timings(const struct v4l2_dv_timings *measured,
                          const struct v4l2_dv_timings *standard,
                          unsigned pclock_delta);
 
+/** v4l2_print_dv_timings() - log the contents of a dv_timings struct
+  * @dev_prefix:device prefix for each log line.
+  * @prefix:   additional prefix for each log line, may be NULL.
+  * @t:                the timings data.
+  * @detailed: if true, give a detailed log.
+  */
+void v4l2_print_dv_timings(const char *dev_prefix, const char *prefix,
+                          const struct v4l2_dv_timings *t, bool detailed);
+
 /** v4l2_detect_cvt - detect if the given timings follow the CVT standard
  * @frame_height - the total height of the frame (including blanking) in lines.
  * @hfreq - the horizontal frequency in Hz.