]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
scsi: dpt_i2o: Add a missing call to kfree
authorQuentin Lambert <lambert.quentin@gmail.com>
Sat, 19 Nov 2016 17:42:34 +0000 (18:42 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 29 Nov 2016 16:54:40 +0000 (11:54 -0500)
Most error branches following the call to kzalloc contain a call to
kfree. This patch add these calls where they are missing.

This issue was found with Hector.

Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/dpt_i2o.c

index d84004b5d3e055ed68bc925c9c4fa78d415c4a0b..f88b3d216a88bb15b5c556f0e205226df592f18d 100644 (file)
@@ -1754,8 +1754,10 @@ static int adpt_i2o_passthru(adpt_hba* pHba, u32 __user *arg)
        sg_offset = (msg[0]>>4)&0xf;
        msg[2] = 0x40000000; // IOCTL context
        msg[3] = adpt_ioctl_to_context(pHba, reply);
-       if (msg[3] == (u32)-1)
+       if (msg[3] == (u32)-1) {
+               kfree(reply);
                return -EBUSY;
+       }
 
        memset(sg_list,0, sizeof(sg_list[0])*pHba->sg_tablesize);
        if(sg_offset) {