]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ASoC: omap: rx51: Add some error messages
authorSebastian Reichel <sre@kernel.org>
Mon, 28 Apr 2014 14:07:25 +0000 (16:07 +0200)
committerMark Brown <broonie@linaro.org>
Thu, 1 May 2014 17:54:35 +0000 (10:54 -0700)
Add more error messages making it easier to identify problems.

Signed-off-by: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/omap/rx51.c

index 30cfac023138548434861c1113e49a61b24fdc16..110deca7fcbb75554ce752512c618039dccf1ef7 100644 (file)
@@ -298,20 +298,26 @@ static int rx51_aic34_init(struct snd_soc_pcm_runtime *rtd)
        snd_soc_dapm_nc_pin(dapm, "LINE1R");
 
        err = tpa6130a2_add_controls(codec);
-       if (err < 0)
+       if (err < 0) {
+               dev_err(card->dev, "Failed to add TPA6130A2 controls\n");
                return err;
+       }
        snd_soc_limit_volume(codec, "TPA6130A2 Headphone Playback Volume", 42);
 
        err = omap_mcbsp_st_add_controls(rtd, 2);
-       if (err < 0)
+       if (err < 0) {
+               dev_err(card->dev, "Failed to add MCBSP controls\n");
                return err;
+       }
 
        /* AV jack detection */
        err = snd_soc_jack_new(codec, "AV Jack",
                               SND_JACK_HEADSET | SND_JACK_VIDEOOUT,
                               &rx51_av_jack);
-       if (err)
+       if (err) {
+               dev_err(card->dev, "Failed to add AV Jack\n");
                return err;
+       }
 
        /* prepare gpio for snd_soc_jack_add_gpios */
        rx51_av_jack_gpios[0].gpio = desc_to_gpio(pdata->jack_detection_gpio);
@@ -320,6 +326,10 @@ static int rx51_aic34_init(struct snd_soc_pcm_runtime *rtd)
        err = snd_soc_jack_add_gpios(&rx51_av_jack,
                                     ARRAY_SIZE(rx51_av_jack_gpios),
                                     rx51_av_jack_gpios);
+       if (err) {
+               dev_err(card->dev, "Failed to add GPIOs\n");
+               return err;
+       }
 
        return err;
 }