]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
nfsd: fix endianness breakage in TEST_STATEID handling
authorAl Viro <viro@zeniv.linux.org.uk>
Fri, 13 Apr 2012 04:10:34 +0000 (00:10 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 13 Apr 2012 14:12:01 +0000 (10:12 -0400)
->ts_id_status gets nfs errno, i.e. it's already big-endian; no need
to apply htonl() to it.  Broken by commit 174568 (NFSD: Added TEST_STATEID
operation) last year...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/nfsd/nfs4xdr.c

index bcd8904ab1e36dd807f26379392000fb114f9bc6..07a99b6d4bbe2c95597f35adc0654644132449fe 100644 (file)
@@ -3410,7 +3410,7 @@ nfsd4_encode_test_stateid(struct nfsd4_compoundres *resp, int nfserr,
        *p++ = htonl(test_stateid->ts_num_ids);
 
        list_for_each_entry_safe(stateid, next, &test_stateid->ts_stateid_list, ts_id_list) {
-               *p++ = htonl(stateid->ts_id_status);
+               *p++ = stateid->ts_id_status;
        }
 
        ADJUST_ARGS();