HID: sony: remove redundant check for -ve err

err is being checked for failure each time it is being updated
so this err check is totally redundant and can be removed

Detected with CoverityScan, CID#1420665 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index e90ce63897df204f2b6a68515f90280b356dae7c..43213d6ff2d198306c61dab8e089f1585fd3948d 100644 (file)
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -2654,9 +2654,6 @@ static int sony_input_configured(struct hid_device *hdev,
                ret = 0;
        }
 
-       if (ret < 0)
-               goto err_stop;
-
        if (sc->quirks & SONY_LED_SUPPORT) {
                ret = sony_leds_init(sc);
                if (ret < 0)