]> git.karo-electronics.de Git - linux-beck.git/commitdiff
drm/crtc_helper/set_config: Remove redundant handling when set->fb is NULL
authorLiu Ying <gnuiyl@gmail.com>
Thu, 14 Jan 2016 06:00:09 +0000 (14:00 +0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 18 Jan 2016 06:51:10 +0000 (07:51 +0100)
We've done sanity NULL pointer check on set->fb at the beginning of
drm_crtc_helper_set_config() and bailed out if necessary, thus any later on
check or case handling is redundant.

Signed-off-by: Liu Ying <gnuiyl@gmail.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1452751210-19216-1-git-send-email-gnuiyl@gmail.com
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_crtc_helper.c

index a02a7f9a6a9d872cbf5be0fdf521f8e9512ebe0b..63e88819b91e7964d750af636af9720b35acf4cc 100644 (file)
@@ -578,8 +578,6 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set)
                if (set->crtc->primary->fb == NULL) {
                        DRM_DEBUG_KMS("crtc has no fb, full mode set\n");
                        mode_changed = true;
-               } else if (set->fb == NULL) {
-                       mode_changed = true;
                } else if (set->fb->pixel_format !=
                           set->crtc->primary->fb->pixel_format) {
                        mode_changed = true;