]> git.karo-electronics.de Git - linux-beck.git/commitdiff
mtd: nandsim: drop null test before destroy functions
authorJulia Lawall <julia.lawall@lip6.fr>
Sun, 13 Sep 2015 12:14:54 +0000 (14:14 +0200)
committerBrian Norris <computersforpeace@gmail.com>
Tue, 22 Sep 2015 00:04:50 +0000 (17:04 -0700)
Remove unneeded NULL test.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ expression x; @@
-if (x != NULL)
  \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
drivers/mtd/nand/nandsim.c

index 95d0cc49cfc2f4e37013f3e1bfc176d3c1b2ec78..b16d70aafd9ecb3d241fa91956cbe498a0fdb83e 100644 (file)
@@ -649,8 +649,7 @@ static void free_device(struct nandsim *ns)
                                kmem_cache_free(ns->nand_pages_slab,
                                                ns->pages[i].byte);
                }
-               if (ns->nand_pages_slab)
-                       kmem_cache_destroy(ns->nand_pages_slab);
+               kmem_cache_destroy(ns->nand_pages_slab);
                vfree(ns->pages);
        }
 }