]> git.karo-electronics.de Git - linux-beck.git/commitdiff
[media] siano: remove a bogus printk line
authorMauro Carvalho Chehab <mchehab@redhat.com>
Tue, 19 Mar 2013 15:59:50 +0000 (12:59 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 21 Mar 2013 10:53:42 +0000 (07:53 -0300)
The logic that detects the types of sms devices is bogus. It returns
[ 4645.187790] smsusb_init_device: line: 372: Unspecified sms device type!
For several devices, including the one I have (SMS_RIO). In a matter
of fact, the right thing to do there is to print an error only if
the device is really unknown (SMS_UNKNOWN_TYPE).

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/usb/siano/smsusb.c

index def5e41405a441e88888b1a021bc67dfa4a4030a..01a0f39a7cecd151300a050a6e6833a0d2a6d7ea 100644 (file)
@@ -368,14 +368,10 @@ static int smsusb_init_device(struct usb_interface *intf, int board_id)
                params.setmode_handler = smsusb1_setmode;
                params.detectmode_handler = smsusb1_detectmode;
                break;
-       default:
+       case SMS_UNKNOWN_TYPE:
                sms_err("Unspecified sms device type!");
                /* fall-thru */
-       case SMS_NOVA_A0:
-       case SMS_NOVA_B0:
-       case SMS_VEGA:
-       case SMS_VENICE:
-       case SMS_DENVER_1530:
+       default:
                dev->buffer_size = USB2_BUFFER_SIZE;
                dev->response_alignment =
                    le16_to_cpu(dev->udev->ep_in[1]->desc.wMaxPacketSize) -