]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
isci: fix missed unlock in apc_agent_timeout()
authorJeff Skirvin <jeffrey.d.skirvin@intel.com>
Thu, 29 Sep 2011 01:35:32 +0000 (18:35 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 11 Nov 2011 17:42:31 +0000 (09:42 -0800)
commit 983d3fdd332742167d0482c06fd29cf4b8a687c0 upstream.

Needed to jump to scic_lock unlock.

Also spotted by coccicheck.

Signed-off-by: Jeff Skirvin <jeffrey.d.skirvin@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/scsi/isci/port_config.c

index 486b113c634a4810652f11a4aa197c551a07c390..38a99d2811411d102220a96bdf918579fb47546b 100644 (file)
@@ -678,7 +678,7 @@ static void apc_agent_timeout(unsigned long data)
        configure_phy_mask = ~port_agent->phy_configured_mask & port_agent->phy_ready_mask;
 
        if (!configure_phy_mask)
-               return;
+               goto done;
 
        for (index = 0; index < SCI_MAX_PHYS; index++) {
                if ((configure_phy_mask & (1 << index)) == 0)