]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ALSA: hda/via - Disable broken dynamic power control
authorTakashi Iwai <tiwai@suse.de>
Fri, 31 May 2013 11:54:10 +0000 (13:54 +0200)
committerTakashi Iwai <tiwai@suse.de>
Mon, 3 Jun 2013 09:32:55 +0000 (11:32 +0200)
Since the transition to the generic parser, the actual routes used
there don't match always with the assumed static paths in some
set_widgets_power_state callbacks.  This results in the wrong power
setup in the end.  As a temporary workaround, we need to disable the
calls together with the non-functional dynamic power control enum.

Reported-by: Alex Riesen <raa.lkml@gmail.com>
Cc: <stable@vger.kernel.org> [v3.9]
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_via.c

index e0dadcf2030d6995197a47c025b085fb7b70a7e3..75fdb51345a74218f0c3d877ba094edb6fb45d10 100644 (file)
@@ -231,9 +231,14 @@ static void vt1708_update_hp_work(struct hda_codec *codec)
 
 static void set_widgets_power_state(struct hda_codec *codec)
 {
+#if 0 /* FIXME: the assumed connections don't match always with the
+       * actual routes by the generic parser, so better to disable
+       * the control for safety.
+       */
        struct via_spec *spec = codec->spec;
        if (spec->set_widgets_power_state)
                spec->set_widgets_power_state(codec);
+#endif
 }
 
 static void update_power_state(struct hda_codec *codec, hda_nid_t nid,