net/mlx5e: Reduce number of heap allocated buffers for update stats

Allocating buffers on the heap every 200ms is something we should avoid,
let's use buffers located on the stack instead.

Signed-off-by: Gal Pressman <galp@mellanox.com>
Reviewed-by: Eran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Cc: kernel-team@fb.com

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index 51f686d737cbdde3ca7c8c233844e0a383c3648a..50184021624e2e72e5225b4a0b36075a09c971fc 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -248,14 +248,10 @@ static void mlx5e_update_pport_counters(struct mlx5e_priv *priv)
 {
        struct mlx5e_pport_stats *pstats = &priv->stats.pport;
        struct mlx5_core_dev *mdev = priv->mdev;
+       u32 in[MLX5_ST_SZ_DW(ppcnt_reg)] = {0};
        int sz = MLX5_ST_SZ_BYTES(ppcnt_reg);
        int prio;
        void *out;
-       u32 *in;
-
-       in = kvzalloc(sz, GFP_KERNEL);
-       if (!in)
-               return;
 
        MLX5_SET(ppcnt_reg, in, local_port, 1);
 
@@ -288,8 +284,6 @@ static void mlx5e_update_pport_counters(struct mlx5e_priv *priv)
                mlx5_core_access_reg(mdev, in, sz, out, sz,
                                     MLX5_REG_PPCNT, 0, 0);
        }
-
-       kvfree(in);
 }
 
 static void mlx5e_update_q_counter(struct mlx5e_priv *priv)
@@ -307,22 +301,16 @@ static void mlx5e_update_pcie_counters(struct mlx5e_priv *priv)
 {
        struct mlx5e_pcie_stats *pcie_stats = &priv->stats.pcie;
        struct mlx5_core_dev *mdev = priv->mdev;
+       u32 in[MLX5_ST_SZ_DW(mpcnt_reg)] = {0};
        int sz = MLX5_ST_SZ_BYTES(mpcnt_reg);
        void *out;
-       u32 *in;
 
        if (!MLX5_CAP_MCAM_FEATURE(mdev, pcie_performance_group))
                return;
 
-       in = kvzalloc(sz, GFP_KERNEL);
-       if (!in)
-               return;
-
        out = pcie_stats->pcie_perf_counters;
        MLX5_SET(mpcnt_reg, in, grp, MLX5_PCIE_PERFORMANCE_COUNTERS_GROUP);
        mlx5_core_access_reg(mdev, in, sz, out, sz, MLX5_REG_MPCNT, 0, 0);
-
-       kvfree(in);
 }
 
 void mlx5e_update_stats(struct mlx5e_priv *priv)