batman-adv: Place kref_get for orig_node_vlan near use

It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems caused by incorrect reference counting.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>

diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c
index 95c85558c53067b5c57a4c16f58b12558f65e0ce..5108af11a6e932f96e95d0882334b11aa00f5dcb 100644 (file)
--- a/net/batman-adv/originator.c
+++ b/net/batman-adv/originator.c
@@ -133,9 +133,9 @@ batadv_orig_node_vlan_new(struct batadv_orig_node *orig_node,
                goto out;
 
        kref_init(&vlan->refcount);
-       kref_get(&vlan->refcount);
        vlan->vid = vid;
 
+       kref_get(&vlan->refcount);
        hlist_add_head_rcu(&vlan->list, &orig_node->vlan_list);
 
 out: