]> git.karo-electronics.de Git - linux-beck.git/commitdiff
tpm/st33zp24: Remove useless tpm_gen_interrupt
authorJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Tue, 19 Jul 2016 20:38:55 +0000 (14:38 -0600)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Thu, 15 Sep 2016 13:04:21 +0000 (16:04 +0300)
This function should only be called as part of an IRQ probing protocol
and st33 does not have any code to detect that the IRQ it tries to
generate was not generated and disable the IRQ.

Since st33 is primarily a DT binding driver it should not be doing
IRQ probing anyhow, so let us just delete this useless call.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
drivers/char/tpm/st33zp24/st33zp24.c

index c2ee30451e41d8632b01ae538f659aeb24a6e83d..6f060c76217b9a7ea02ab19b8909e7d708578bd5 100644 (file)
@@ -589,8 +589,6 @@ int st33zp24_probe(void *phy_id, const struct st33zp24_phy_ops *ops,
                chip->flags |= TPM_CHIP_FLAG_IRQ;
 
                disable_irq_nosync(tpm_dev->irq);
-
-               tpm_gen_interrupt(chip);
        }
 
        return tpm_chip_register(chip);