]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
bcache: Fix a dumb journal discard bug
authorKent Overstreet <kmo@daterainc.com>
Tue, 24 Sep 2013 06:17:27 +0000 (23:17 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Oct 2013 14:13:09 +0000 (07:13 -0700)
commit 6d9d21e35fbfa2934339e96934f862d118abac23 upstream.

That switch statement was obviously wrong, leading to some sort of weird
spinning on rare occasion with discards enabled...

Signed-off-by: Kent Overstreet <kmo@daterainc.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/bcache/journal.c

index b49abb246bb69f61e4d865843d597e55dc8409c4..fb1bfafa21e43b975fabc7334553c13fe9407a01 100644 (file)
@@ -425,7 +425,7 @@ static void do_journal_discard(struct cache *ca)
                return;
        }
 
-       switch (atomic_read(&ja->discard_in_flight) == DISCARD_IN_FLIGHT) {
+       switch (atomic_read(&ja->discard_in_flight)) {
        case DISCARD_IN_FLIGHT:
                return;