]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
irqdomain: Mask irq type in irq_domain_xlate_onetwocell()
authorSebastian Frias <sf84@laposte.net>
Tue, 2 Aug 2016 08:52:45 +0000 (10:52 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 2 Sep 2016 16:06:50 +0000 (18:06 +0200)
According to the xlate() callback definition, the 'out_type' parameter
needs to be the "linux irq type".

A mask for such bits exists, IRQ_TYPE_SENSE_MASK, which is correctly
applied in irq_domain_xlate_twocell()

So use it for irq_domain_xlate_onetwocell() as well.

Signed-off-by: Sebastian Frias <sf84@laposte.net>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Mason <slash.tmp@free.fr>
Cc: Jason Cooper <jason@lakedaemon.net>
Link: http://lkml.kernel.org/r/57A05F5D.103@laposte.net
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/irq/irqdomain.c

index 4752b43662e0017c343e3f3fa6dd013c23072778..f10cffe8aefb66f406c54ed7d146a01fb56a9232 100644 (file)
@@ -868,7 +868,10 @@ int irq_domain_xlate_onetwocell(struct irq_domain *d,
        if (WARN_ON(intsize < 1))
                return -EINVAL;
        *out_hwirq = intspec[0];
-       *out_type = (intsize > 1) ? intspec[1] : IRQ_TYPE_NONE;
+       if (intsize > 1)
+               *out_type = intspec[1] & IRQ_TYPE_SENSE_MASK;
+       else
+               *out_type = IRQ_TYPE_NONE;
        return 0;
 }
 EXPORT_SYMBOL_GPL(irq_domain_xlate_onetwocell);