mm-reduce-the-amount-of-work-done-when-updating-min_free_kbytes-checkpatch-fixes

Cc: Mel Gorman <mgorman@suse.de>
WARNING: line over 80 characters
#42: FILE: mm/page_alloc.c:3464:
+			/* Blocks with reserved pages will never free, skip them. */

WARNING: line over 80 characters
#61: FILE: mm/page_alloc.c:3477:
+				set_pageblock_migratetype(page, MIGRATE_RESERVE);

WARNING: line over 80 characters
#62: FILE: mm/page_alloc.c:3478:
+				move_freepages_block(zone, page, MIGRATE_RESERVE);

total: 0 errors, 3 warnings, 44 lines checked

./patches/mm-reduce-the-amount-of-work-done-when-updating-min_free_kbytes.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Mel Gorman <mgorman@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index f2c63c37df56e2d23d02b90d67c9c1e339edacfa..f9d5c3a89985d496d4c13cf526f996deb9b023b4 100644 (file)
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3434,7 +3434,10 @@ static void setup_zone_migrate_reserve(struct zone *zone)
 
                /* Only test what is necessary when the reserves are not met */
                if (reserve > 0) {
-                       /* Blocks with reserved pages will never free, skip them. */
+                       /*
+                        * Blocks with reserved pages will never free, skip
+                        * them.
+                        */
                        block_end_pfn = min(pfn + pageblock_nr_pages, end_pfn);
                        if (pageblock_is_reserved(pfn, block_end_pfn))
                                continue;
@@ -3447,8 +3450,10 @@ static void setup_zone_migrate_reserve(struct zone *zone)
 
                        /* Suitable for reserving if this block is movable */
                        if (block_migratetype == MIGRATE_MOVABLE) {
-                               set_pageblock_migratetype(page, MIGRATE_RESERVE);
-                               move_freepages_block(zone, page, MIGRATE_RESERVE);
+                               set_pageblock_migratetype(page,
+                                                       MIGRATE_RESERVE);
+                               move_freepages_block(zone, page,
+                                                       MIGRATE_RESERVE);
                                reserve--;
                                continue;
                        }