]> git.karo-electronics.de Git - linux-beck.git/commitdiff
tc1100-wmi: Delete an unnecessary check before the function call "kfree"
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 26 Jun 2015 19:21:16 +0000 (21:21 +0200)
committerDarren Hart <dvhart@linux.intel.com>
Fri, 26 Jun 2015 22:55:51 +0000 (15:55 -0700)
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
drivers/platform/x86/tc1100-wmi.c

index e36542564131018cb5985a19ad52fea1c2b46726..89aa976f0ab2a17c8cbed83bace078bf555c7384 100644 (file)
@@ -82,7 +82,7 @@ static int get_state(u32 *out, u8 instance)
                tmp = 0;
        }
 
-       if (result.length > 0 && result.pointer)
+       if (result.length > 0)
                kfree(result.pointer);
 
        switch (instance) {