]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: brcm80211: bugfix for crash on heavy transmit traffic
authorRoland Vossen <rvossen@broadcom.com>
Mon, 21 Feb 2011 08:07:12 +0000 (09:07 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 23 Feb 2011 22:05:42 +0000 (14:05 -0800)
With heavy transmit traffic, once in a while (range 15mins-1hr)
a tx packet was added to a full transmit queue. Under certain
conditions an other packet in the queue gets bumped to make room
for the new packet. This is not considered an error condition, but
normal operation. Despite that, there was an ASSERT(0) that caused
the driver to oops. The ASSERT(0) has been removed. Driver was tested
afterwards.

Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c

index 91a2de218e77c777d175f7e35c9e34aa0a03f236..b617b6417054dc12463f4cb39113eb9d3aa9d63a 100644 (file)
@@ -5146,8 +5146,6 @@ wlc_prec_enq_head(struct wlc_info *wlc, struct pktq *q, struct sk_buff *pkt,
                                 tx_failed[WME_PRIO2AC(p->priority)].bytes,
                                 pkttotlen(wlc->osh, p));
                }
-
-               ASSERT(0);
                pkt_buf_free_skb(wlc->osh, p, true);
                wlc->pub->_cnt->txnobuf++;
        }