]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
Fix detection of the need to resize the dm thin metadata device.
authorAlasdair G Kergon <agk@redhat.com>
Mon, 20 May 2013 00:00:00 +0000 (10:00 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Mon, 20 May 2013 00:00:00 +0000 (10:00 +1000)
The code incorrectly tried to extend the metadata device when it
didn't need to due to a merging error with patch 24347e9 ("dm thin:
detect metadata device resizing").

  device-mapper: transaction manager: couldn't open metadata space map
  device-mapper: thin metadata: tm_open_with_sm failed
  device-mapper: thin: aborting transaction failed
  device-mapper: thin: switching pool to failure mode

Signed-off-by: Alasdair G Kergon <agk@redhat.com>
drivers/md/dm-thin.c

index 759cffc45cabce8414c883f329b52fd56513bccf..88f2f802d528be23b8e64c26085913677082be03 100644 (file)
@@ -2188,7 +2188,7 @@ static int maybe_resize_metadata_dev(struct dm_target *ti, bool *need_commit)
 
        *need_commit = false;
 
-       metadata_dev_size = get_metadata_dev_size(pool->md_dev);
+       metadata_dev_size = get_metadata_dev_size_in_blocks(pool->md_dev);
 
        r = dm_pool_get_metadata_dev_size(pool->pmd, &sb_metadata_dev_size);
        if (r) {
@@ -2197,7 +2197,7 @@ static int maybe_resize_metadata_dev(struct dm_target *ti, bool *need_commit)
        }
 
        if (metadata_dev_size < sb_metadata_dev_size) {
-               DMERR("metadata device (%llu sectors) too small: expected %llu",
+               DMERR("metadata device (%llu blocks) too small: expected %llu",
                      metadata_dev_size, sb_metadata_dev_size);
                return -EINVAL;