]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
i7300_edac: Add a FIXME note about the error correction type
authorMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 27 Aug 2010 02:19:54 +0000 (23:19 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 30 Aug 2010 17:56:45 +0000 (14:56 -0300)
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/edac/i7300_edac.c

index 7e035b6d0d0f1456fa62185a96304314a96d8b08..36265e21fef21d8d45def7fcf763547b25fdfa48 100644 (file)
@@ -841,6 +841,15 @@ static int decode_mtr(struct i7300_pvt *pvt,
        p_csrow->grain = 8;
        p_csrow->nr_pages = dinfo->megabytes << 8;
        p_csrow->mtype = MEM_FB_DDR2;
+
+       /*
+        * FIXME: the type of error detection actually depends of the
+        * mode of operation. When it is just one single memory chip, at
+        * socket 0, channel 0, it uses  8-byte-over-32-byte SECDED+ code.
+        * In normal or mirrored mode, it uses Single Device Data correction,
+        * with the possibility of using an extended algorithm for x8 memories
+        * See datasheet Sections 7.3.6 to 7.3.8
+        */
        p_csrow->edac_mode = EDAC_S8ECD8ED;
 
        /* ask what device type on this row */