]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
printk: remove bounds checking for log_prefix
authorWilliam Douglas <william.r.douglas@gmail.com>
Wed, 5 Oct 2011 00:43:28 +0000 (11:43 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Fri, 7 Oct 2011 06:06:53 +0000 (17:06 +1100)
Currently log_prefix is testing that the first character of the log level
and facility is less than '0' and greater than '9' (which is always
false).

Since the code being updated works because strtoul bombs out (endp isn't
updated) and 0 is returned anyway just remove the check and don't change
the behavior of the function.

Signed-off-by: William Douglas <william.douglas@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/printk.c

index 286d2c7be52c9ad44c76fa506fe62457830da5e2..1455a0d4eedd4b386c759d689f939ba5d7a9007a 100644 (file)
@@ -595,9 +595,6 @@ static size_t log_prefix(const char *p, unsigned int *level, char *special)
                /* multi digit including the level and facility number */
                char *endp = NULL;
 
-               if (p[1] < '0' || p[1] > '9')
-                       return 0;
-
                lev = (simple_strtoul(&p[1], &endp, 10) & 7);
                if (endp == NULL || endp[0] != '>')
                        return 0;