]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
net: ethernet: altera_tse: use phy_ethtool_{get|set}_link_ksettings
authorPhilippe Reynes <tremyfr@gmail.com>
Sat, 18 Jun 2016 14:37:21 +0000 (16:37 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 22 Jun 2016 20:22:41 +0000 (16:22 -0400)
There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.

Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/altera/altera_tse_ethtool.c

index c1b56080a3d1042d7921a0b185832373609315f9..7c367713c3e604738257478816f1349483ee7087 100644 (file)
@@ -233,38 +233,18 @@ static void tse_get_regs(struct net_device *dev, struct ethtool_regs *regs,
                buf[i] = csrrd32(priv->mac_dev, i * 4);
 }
 
-static int tse_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
-{
-       struct phy_device *phydev = dev->phydev;
-
-       if (phydev == NULL)
-               return -ENODEV;
-
-       return phy_ethtool_gset(phydev, cmd);
-}
-
-static int tse_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
-{
-       struct phy_device *phydev = dev->phydev;
-
-       if (phydev == NULL)
-               return -ENODEV;
-
-       return phy_ethtool_sset(phydev, cmd);
-}
-
 static const struct ethtool_ops tse_ethtool_ops = {
        .get_drvinfo = tse_get_drvinfo,
        .get_regs_len = tse_reglen,
        .get_regs = tse_get_regs,
        .get_link = ethtool_op_get_link,
-       .get_settings = tse_get_settings,
-       .set_settings = tse_set_settings,
        .get_strings = tse_gstrings,
        .get_sset_count = tse_sset_count,
        .get_ethtool_stats = tse_fill_stats,
        .get_msglevel = tse_get_msglevel,
        .set_msglevel = tse_set_msglevel,
+       .get_link_ksettings = phy_ethtool_get_link_ksettings,
+       .set_link_ksettings = phy_ethtool_set_link_ksettings,
 };
 
 void altera_tse_set_ethtool_ops(struct net_device *netdev)