]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
1394: fix for recently added firewire patch that breaks things on ppc
authorDanny Tholen <obiwan@mailmij.org>
Wed, 23 Aug 2006 17:28:41 +0000 (19:28 +0200)
committerAdrian Bunk <bunk@stusta.de>
Wed, 23 Aug 2006 17:28:41 +0000 (19:28 +0200)
Recently a patch was added for preliminary suspend/resume handling on
!PPC_PMAC.  However, this broke both suspend and firewire on powerpc
because it saves the pci state after the device has already been disabled.

This moves the save state to before the pmac specific code.

Signed-off-by: Danny Tholen <obiwan@mailmij.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
drivers/ieee1394/ohci1394.c

index f852ae7abe37e6e9d1a4188d290f61157335bb28..1bd98e7716d1202d843b64f273c30be35c113879 100644 (file)
@@ -3545,6 +3545,8 @@ static int ohci1394_pci_resume (struct pci_dev *pdev)
 
 static int ohci1394_pci_suspend (struct pci_dev *pdev, pm_message_t state)
 {
+       pci_save_state(pdev);
+
 #ifdef CONFIG_PPC_PMAC
        if (_machine == _MACH_Pmac) {
                struct device_node *of_node;
@@ -3556,8 +3558,6 @@ static int ohci1394_pci_suspend (struct pci_dev *pdev, pm_message_t state)
        }
 #endif
 
-       pci_save_state(pdev);
-
        return 0;
 }