]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
mailbox/xgene-slimpro: Checking for IS_ERR instead of NULL
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 25 Feb 2016 21:32:21 +0000 (00:32 +0300)
committerJassi Brar <jaswinder.singh@linaro.org>
Fri, 4 Mar 2016 07:02:20 +0000 (12:32 +0530)
devm_ioremap() returns NULL, it never returns an ERR_PTR.

Fixes: f700e84f417b ('mailbox: Add support for APM X-Gene platform mailbox driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/mailbox-xgene-slimpro.c

index b5f51062b1f7f945914991b614ddb04d441db351..bd07f39f06926dad75c7dfc4759c449b86af3ce2 100644 (file)
@@ -196,8 +196,8 @@ static int slimpro_mbox_probe(struct platform_device *pdev)
 
        regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        mb_base = devm_ioremap(&pdev->dev, regs->start, resource_size(regs));
-       if (IS_ERR(mb_base))
-               return PTR_ERR(mb_base);
+       if (!mb_base)
+               return -ENOMEM;
 
        /* Setup mailbox links */
        for (i = 0; i < MBOX_CNT; i++) {