]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
rio: typo in bitwise AND expression.
authorWilly Tarreau <w@1wt.eu>
Sat, 6 Jan 2007 01:31:24 +0000 (02:31 +0100)
committerAdrian Bunk <bunk@stusta.de>
Tue, 9 Jan 2007 02:23:31 +0000 (03:23 +0100)
The line:

    hp->Mode &= !RIO_PCI_INT_ENABLE;

is obviously wrong as RIO_PCI_INT_ENABLE=0x04 and is used as a bitmask
2 lines before. Getting no IRQ would not disable RIO_PCI_INT_ENABLE
but rather RIO_PCI_BOOT_FROM_RAM which equals 0x01.

Obvious fix is to change ! for ~.

Signed-off-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
drivers/char/rio/rio_linux.c

index c9af283a811dc2c84f6153637df2c30d14ba8463..06bd77f04e8508e02db755a9f6619bcdf8536394 100644 (file)
@@ -1186,7 +1186,7 @@ static int __init rio_init(void)
                                rio_dprintk(RIO_DEBUG_INIT, "Enabling interrupts on rio card.\n");
                                hp->Mode |= RIO_PCI_INT_ENABLE;
                        } else
-                               hp->Mode &= !RIO_PCI_INT_ENABLE;
+                               hp->Mode &= ~RIO_PCI_INT_ENABLE;
                        rio_dprintk(RIO_DEBUG_INIT, "New Mode: %x\n", hp->Mode);
                        rio_start_card_running(hp);
                }