staging: i4l: pcbit: layer2: use setup_timer() and mod_timer().

Use setup_timer() instead of init_timer(), being the preferred/standard
way to set a timer up.

Also, quoting the mod_timer() function comment:
-> mod_timer() is a more efficient way to update the expire field of an
   active timer (if the timer is inactive it will be activated).

Use setup_timer and mod_timer to setup and arm a timer, to make the code
cleaner and easier to read.

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/i4l/pcbit/layer2.c b/drivers/staging/i4l/pcbit/layer2.c
index 46e1240ae0741a54008a976602b11a90f00ea685..a136c72547e5c740c8c2bf891c35685810e49982 100644 (file)
--- a/drivers/staging/i4l/pcbit/layer2.c
+++ b/drivers/staging/i4l/pcbit/layer2.c
@@ -645,11 +645,9 @@ pcbit_l2_error(struct pcbit_dev *dev)
 
                dev->l2_state = L2_DOWN;
 
-               init_timer(&dev->error_recover_timer);
-               dev->error_recover_timer.function = &pcbit_l2_err_recover;
-               dev->error_recover_timer.data = (ulong) dev;
-               dev->error_recover_timer.expires = jiffies + ERRTIME;
-               add_timer(&dev->error_recover_timer);
+               setup_timer(&dev->error_recover_timer, &pcbit_l2_err_recover,
+                           (ulong)dev);
+               mod_timer(&dev->error_recover_timer, jiffies + ERRTIME);
        }
 }