]> git.karo-electronics.de Git - linux-beck.git/commitdiff
PCI: Delete unnecessary NULL pointer checks
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 26 Dec 2014 23:28:08 +0000 (16:28 -0700)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 26 Dec 2014 23:28:08 +0000 (16:28 -0700)
The pci_dev_put() function tests whether its argument is NULL and then
returns immediately.  Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/hotplug/cpci_hotplug_core.c

index a5a7fd8332ac1cb7557285298d2824a05f127f00..46db29395a62b0cdec6400f7bc4d8e781b604592 100644 (file)
@@ -214,8 +214,7 @@ static void release_slot(struct hotplug_slot *hotplug_slot)
 
        kfree(slot->hotplug_slot->info);
        kfree(slot->hotplug_slot);
-       if (slot->dev)
-               pci_dev_put(slot->dev);
+       pci_dev_put(slot->dev);
        kfree(slot);
 }