md-cluster: remove inappropriate try_module_get from join()

md_setup_cluster already calls try_module_get(), so this
try_module_get isn't needed.
Also, there is no matching module_put (except in error patch),
so this leaves an unbalanced module count.

Signed-off-by: NeilBrown <neilb@suse.com>

diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
index c35a03a7eb1184c7becd6370770e57c950c89371..11e3bc9d2a4b8377a940dde49fffd2ce36bec9ad 100644 (file)
--- a/drivers/md/md-cluster.c
+++ b/drivers/md/md-cluster.c
@@ -687,9 +687,6 @@ static int join(struct mddev *mddev, int nodes)
        int ret, ops_rv;
        char str[64];
 
-       if (!try_module_get(THIS_MODULE))
-               return -ENOENT;
-
        cinfo = kzalloc(sizeof(struct md_cluster_info), GFP_KERNEL);
        if (!cinfo)
                return -ENOMEM;
@@ -771,7 +768,6 @@ err:
                dlm_release_lockspace(cinfo->lockspace, 2);
        mddev->cluster_info = NULL;
        kfree(cinfo);
-       module_put(THIS_MODULE);
        return ret;
 }