]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
USB: cp210x: fix up set_termios variables
authorJohan Hovold <jhovold@gmail.com>
Sun, 15 Jan 2012 23:36:49 +0000 (00:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Feb 2012 17:19:06 +0000 (09:19 -0800)
commit 34b76fcaee574017862ea3fa0efdcd77a9d0e57d upstream.

[Based on a patch from Johan, mangled by gregkh to keep things in line]

Fix up the variable usage in the set_termios call.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Cc: Preston Fick <preston.fick@silabs.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/cp210x.c

index 1bac7b9223f22dea187ff0a06ec5d6d104d200f8..5c3b7d1c25a565e7de52a723418de657f8a1ac4a 100644 (file)
@@ -576,7 +576,8 @@ static void cp210x_set_termios(struct tty_struct *tty,
                struct usb_serial_port *port, struct ktermios *old_termios)
 {
        unsigned int cflag, old_cflag;
-       unsigned int baud = 0, bits;
+       u32 baud;
+       unsigned int bits;
        unsigned int modem_ctl[4];
 
        dbg("%s - port %d", __func__, port->number);
@@ -593,7 +594,7 @@ static void cp210x_set_termios(struct tty_struct *tty,
        if (baud != tty_termios_baud_rate(old_termios) && baud != 0) {
                dbg("%s - Setting baud rate to %d baud", __func__,
                                baud);
-               if (cp210x_set_config(port, CP210X_SET_BAUDRATE, &baud, 4)) {
+               if (cp210x_set_config(port, CP210X_SET_BAUDRATE, &baud, sizeof(baud))) {
                        dbg("Baud rate requested not supported by device");
                        baud = tty_termios_baud_rate(old_termios);
                }