drm/i915: Consolidate i915_vma_unpin_and_release()

In a few places, we repeat a call to clear a pointer to a vma whilst
unpinning and releasing a reference to its owner. Refactor those into a
common function.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1471254551-25805-26-git-send-email-chris@chris-wilson.co.uk

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 738a474c5afa09238db75cb3b7e911f2111843d9..d15eb1d71341a67f5d6570c8208db3379580ffae 100644 (file)
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -3674,3 +3674,15 @@ void __iomem *i915_vma_pin_iomap(struct i915_vma *vma)
        __i915_vma_pin(vma);
        return ptr;
 }
+
+void i915_vma_unpin_and_release(struct i915_vma **p_vma)
+{
+       struct i915_vma *vma;
+
+       vma = fetch_and_zero(p_vma);
+       if (!vma)
+               return;
+
+       i915_vma_unpin(vma);
+       i915_vma_put(vma);
+}

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h b/drivers/gpu/drm/i915/i915_gem_gtt.h
index a2691943a4043107929c3a054bfe33963aab4b21..ec538fcc9c20ba9f26c2401dc0ae6243c2de94f5 100644 (file)
--- a/drivers/gpu/drm/i915/i915_gem_gtt.h
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.h
@@ -232,6 +232,7 @@ struct i915_vma *
 i915_vma_create(struct drm_i915_gem_object *obj,
                struct i915_address_space *vm,
                const struct i915_ggtt_view *view);
+void i915_vma_unpin_and_release(struct i915_vma **p_vma);
 
 static inline bool i915_vma_is_ggtt(const struct i915_vma *vma)
 {

diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c
index c40b92e212fab6680c60cfb071f2b6d7579881a0..e7dbc64ec1da5d196e8dd535413972b1bc64754e 100644 (file)
--- a/drivers/gpu/drm/i915/i915_guc_submission.c
+++ b/drivers/gpu/drm/i915/i915_guc_submission.c
@@ -653,19 +653,6 @@ err:
        return vma;
 }
 
-/**
- * guc_release_vma() - Release gem object allocated for GuC usage
- * @vma:       gem obj to be released
- */
-static void guc_release_vma(struct i915_vma *vma)
-{
-       if (!vma)
-               return;
-
-       i915_vma_unpin(vma);
-       i915_vma_put(vma);
-}
-
 static void
 guc_client_free(struct drm_i915_private *dev_priv,
                struct i915_guc_client *client)
@@ -690,7 +677,7 @@ guc_client_free(struct drm_i915_private *dev_priv,
                kunmap(kmap_to_page(client->client_base));
        }
 
-       guc_release_vma(client->vma);
+       i915_vma_unpin_and_release(&client->vma);
 
        if (client->ctx_index != GUC_INVALID_CTX_ID) {
                guc_fini_ctx_desc(guc, client);
@@ -1048,12 +1035,12 @@ void i915_guc_submission_fini(struct drm_i915_private *dev_priv)
 {
        struct intel_guc *guc = &dev_priv->guc;
 
-       guc_release_vma(fetch_and_zero(&guc->ads_vma));
-       guc_release_vma(fetch_and_zero(&guc->log_vma));
+       i915_vma_unpin_and_release(&guc->ads_vma);
+       i915_vma_unpin_and_release(&guc->log_vma);
 
        if (guc->ctx_pool_vma)
                ida_destroy(&guc->ctx_ids);
-       guc_release_vma(fetch_and_zero(&guc->ctx_pool_vma));
+       i915_vma_unpin_and_release(&guc->ctx_pool_vma);
 }
 
 /**

diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
index 573f642a74f80394d4dd2e3b069e7b7670b2c621..f02d66bbec4b049bdda484e4ead556e77015dc39 100644 (file)
--- a/drivers/gpu/drm/i915/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/intel_engine_cs.c
@@ -279,14 +279,7 @@ err_unref:
 
 static void intel_engine_cleanup_scratch(struct intel_engine_cs *engine)
 {
-       struct i915_vma *vma;
-
-       vma = fetch_and_zero(&engine->scratch);
-       if (!vma)
-               return;
-
-       i915_vma_unpin(vma);
-       i915_vma_put(vma);
+       i915_vma_unpin_and_release(&engine->scratch);
 }
 
 /**

diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 64cb04e635128604e7e3effce1fdb62e411fe1e9..2673fb4f817bee9485e6891d10d7cc7a4e0c9bea 100644 (file)
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -1193,14 +1193,7 @@ err:
 
 static void lrc_destroy_wa_ctx_obj(struct intel_engine_cs *engine)
 {
-       struct i915_vma *vma;
-
-       vma = fetch_and_zero(&engine->wa_ctx.vma);
-       if (!vma)
-               return;
-
-       i915_vma_unpin(vma);
-       i915_vma_put(vma);
+       i915_vma_unpin_and_release(&engine->wa_ctx.vma);
 }
 
 static int intel_init_workaround_bb(struct intel_engine_cs *engine)

diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 30b066140b0ce87443c8b2857d123749ed6c4a70..65ef172e876177e2d045ac388cb5b3b1d0e1bbba 100644 (file)
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -1257,14 +1257,8 @@ static int init_render_ring(struct intel_engine_cs *engine)
 static void render_ring_cleanup(struct intel_engine_cs *engine)
 {
        struct drm_i915_private *dev_priv = engine->i915;
-       struct i915_vma *vma;
-
-       vma = fetch_and_zero(&dev_priv->semaphore);
-       if (!vma)
-               return;
 
-       i915_vma_unpin(vma);
-       i915_vma_put(vma);
+       i915_vma_unpin_and_release(&dev_priv->semaphore);
 }
 
 static int gen8_rcs_signal(struct drm_i915_gem_request *req)