]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ext4: fix abs() usage in ext4_mb_check_group_pa
authorJohn Stultz <john.stultz@linaro.org>
Mon, 19 Oct 2015 04:01:05 +0000 (00:01 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 19 Oct 2015 04:01:05 +0000 (00:01 -0400)
The ext4_fsblk_t type is a long long, which should not be used
with abs(), as is done in ext4_mb_check_group_pa().

This patch modifies ext4_mb_check_group_pa() to use abs64()
instead.

Signed-off-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/mballoc.c

index b4da7f2a5db2d353b811c2c17e64ff7735ed6a1c..1e97ac1dd4bb78756f5c93de22ee47b4b88bc49d 100644 (file)
@@ -3332,8 +3332,8 @@ ext4_mb_check_group_pa(ext4_fsblk_t goal_block,
                atomic_inc(&pa->pa_count);
                return pa;
        }
-       cur_distance = abs(goal_block - cpa->pa_pstart);
-       new_distance = abs(goal_block - pa->pa_pstart);
+       cur_distance = abs64(goal_block - cpa->pa_pstart);
+       new_distance = abs64(goal_block - pa->pa_pstart);
 
        if (cur_distance <= new_distance)
                return cpa;