]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
Staging: comedi: fix printk issue in ni_daq_dio24.c
authorRavishankar karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Mon, 21 Nov 2011 10:37:01 +0000 (16:07 +0530)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sun, 27 Nov 2011 02:51:40 +0000 (18:51 -0800)
This is a patch to the ni_daq_dio24.c file that fixes up a printk
warning found by the checkpatch.pl tool.
Converted printks to pr_<levels> and dev_version.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/comedi/drivers/ni_daq_dio24.c

index 75b3f9aa916f40ad6a063ca39cac92a9bcc2f93e..c0423a8c3e36fb661394e9665f67927fd485cbaa 100644 (file)
@@ -133,21 +133,19 @@ static int dio24_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 #endif
                break;
        default:
-               printk("bug! couldn't determine board type\n");
+               pr_err("bug! couldn't determine board type\n");
                return -EINVAL;
                break;
        }
-       printk("comedi%d: ni_daq_dio24: %s, io 0x%lx", dev->minor,
-              thisboard->name, iobase);
+       pr_debug("comedi%d: ni_daq_dio24: %s, io 0x%lx", dev->minor,
+                thisboard->name, iobase);
 #ifdef incomplete
        if (irq)
-               printk(", irq %u", irq);
+               pr_debug("irq %u\n", irq);
 #endif
 
-       printk("\n");
-
        if (iobase == 0) {
-               printk("io base address is zero!\n");
+               pr_err("io base address is zero!\n");
                return -EINVAL;
        }
 
@@ -172,7 +170,7 @@ static int dio24_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 
 static int dio24_detach(struct comedi_device *dev)
 {
-       printk("comedi%d: ni_daq_dio24: remove\n", dev->minor);
+       dev_info(dev->hw_dev, "comedi%d: ni_daq_dio24: remove\n", dev->minor);
 
        if (dev->subdevices)
                subdev_8255_cleanup(dev, dev->subdevices + 0);