]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: wilc1000: use kmemdup in wilc_edit_station
authorChaehyun Lim <chaehyun.lim@gmail.com>
Sun, 3 Jan 2016 08:35:47 +0000 (17:35 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Feb 2016 23:11:00 +0000 (15:11 -0800)
This patch replaces kmalloc followed by memcpy with kmemdup.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/host_interface.c

index 2f94804e28a0832d98de1cda5da8495139bcecff..290c27aa01848b9ad21264bcd64fcc1395f7b8df 100644 (file)
@@ -4372,13 +4372,11 @@ int wilc_edit_station(struct wilc_vif *vif,
 
        memcpy(add_sta_info, sta_param, sizeof(struct add_sta_param));
        if (add_sta_info->rates_len > 0) {
-               u8 *rates = kmalloc(add_sta_info->rates_len, GFP_KERNEL);
-
+               u8 *rates = kmemdup(sta_param->rates,
+                                   add_sta_info->rates_len,
+                                   GFP_KERNEL);
                if (!rates)
                        return -ENOMEM;
-
-               memcpy(rates, sta_param->rates,
-                      add_sta_info->rates_len);
                add_sta_info->rates = rates;
        }